Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy support #479

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Add proxy support #479

merged 9 commits into from
Dec 12, 2024

Conversation

Jonney
Copy link
Contributor

@Jonney Jonney commented Dec 12, 2024

In the __init__() of solana.rpc.api.Client and solana.rpc.async_api.AsyncClient, a parameter proxy was added, and it is passed to httpx.Client() and httpx.AsyncClient().

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.00%. Comparing base (a5434bc) to head (7feb2e5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files          27       27           
  Lines        2226     2226           
=======================================
  Hits         2048     2048           
  Misses        178      178           

@Jonney Jonney mentioned this pull request Dec 12, 2024
@michaelhly
Copy link
Owner

michaelhly commented Dec 12, 2024

Can you also update the doc strings:

Args:
endpoint: URL of the RPC endpoint.
commitment: Default bank state to query. It can be either "finalized", "confirmed" or "processed".
timeout: HTTP request timeout in seconds.
extra_headers: Extra headers to pass for HTTP request.

endpoint: URL of the RPC endpoint.
commitment: Default bank state to query. It can be either "finalized", "confirmed" or "processed".
timeout: HTTP request timeout in seconds.
extra_headers: Extra headers to pass for HTTP request.

@Jonney
Copy link
Contributor Author

Jonney commented Dec 12, 2024

Can you also update the doc strings:

Args:
endpoint: URL of the RPC endpoint.
commitment: Default bank state to query. It can be either "finalized", "confirmed" or "processed".
timeout: HTTP request timeout in seconds.
extra_headers: Extra headers to pass for HTTP request.

endpoint: URL of the RPC endpoint.
commitment: Default bank state to query. It can be either "finalized", "confirmed" or "processed".
timeout: HTTP request timeout in seconds.
extra_headers: Extra headers to pass for HTTP request.

Completed

src/solana/rpc/api.py Outdated Show resolved Hide resolved
@michaelhly michaelhly merged commit 30e5e70 into michaelhly:master Dec 12, 2024
7 checks passed
@michaelhly michaelhly mentioned this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants