Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use getSignaturesForAddress, deprecate getConfirmedSignaturesForAddress2 #77

Merged
merged 6 commits into from
Jul 6, 2021

Conversation

gqln
Copy link
Contributor

@gqln gqln commented Jul 5, 2021

note: the devnet api doesn't seem to support getSignaturesForAddress yet

closes: #76

@gqln gqln force-pushed the use-get-sigs branch 2 times, most recently from 22cf828 to 2801d09 Compare July 5, 2021 22:27
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #77 (4a33f6f) into master (e4cc525) will decrease coverage by 0.11%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   88.80%   88.68%   -0.12%     
==========================================
  Files          25       25              
  Lines        1429     1441      +12     
==========================================
+ Hits         1269     1278       +9     
- Misses        160      163       +3     

@michaelhly
Copy link
Owner

Looks good! @gqln, would you mind running make format and make lint?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getConfirmedSignaturesForAddress2 -> getConfirmedSignatures
2 participants