Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move decode_byte_string out of tests #91

Merged
merged 1 commit into from
Aug 28, 2021

Conversation

dboures
Copy link
Contributor

@dboures dboures commented Aug 27, 2021

Fixes issue with importing test token caused by having decode_byte_string in the tests module

"
When I try to import the Token type, it fails with:

from spl.token.client import Token as SplToken

File "/usr/local/lib/python3.9/site-packages/spl/token/client.py", line 14, in
from spl.token.core import AccountInfo, MintInfo, _TokenCore
File "/usr/local/lib/python3.9/site-packages/spl/token/core.py", line 18, in
from tests.integration.utils import decode_byte_string
ModuleNotFoundError: No module named 'tests.integration'
"

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #91 (8496e4c) into master (5347a7b) will decrease coverage by 0.09%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   88.30%   88.21%   -0.10%     
==========================================
  Files          32       32              
  Lines        2121     2130       +9     
==========================================
+ Hits         1873     1879       +6     
- Misses        248      251       +3     

@michaelhly michaelhly merged commit 244310a into michaelhly:master Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants