Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemovedInDjango110Warning: SubfieldBase has been deprecated #7

Closed
djch opened this issue Jun 17, 2016 · 2 comments · Fixed by #8
Closed

RemovedInDjango110Warning: SubfieldBase has been deprecated #7

djch opened this issue Jun 17, 2016 · 2 comments · Fixed by #8
Labels
enhancement

Comments

@djch
Copy link

djch commented Jun 17, 2016 •
edited
Loading

Noticed a weird deprecation warning coming from Django 1.9 and tracked it down to this plug-in (which is very useful, thanks for maintaining it).

/venv/lib/python2.7/site-packages/django/utils/six.py:808: RemovedInDjango110Warning: SubfieldBase has been deprecated. Use Field.from_db_value instead.

Refs:
@djch
Copy link
Author

djch commented Jun 17, 2016

Turns out I might have got your plugin confused with a similarly-titled plugin which also uses SubfieldBase ... sorry.

Feel free to close this, assuming it's not relevant 😅

@michaeljohnbarr
Copy link
Owner

Yes, we conditionally use models.SubfieldBase if it is available. I believe it is safe to completely remove this once we fully deprecate support for Django 1.7 and below. According to the Django 1.8 Release Notes, this was deprecated in Django 1.8, so I don't believe that Django 1.8 would be using it anywhere. I am going to leave this ticket open until such a time that this package drops support for versions prior to Django 1.8.

@michaeljohnbarr michaeljohnbarr mentioned this issue Oct 29, 2016
Merged
michaeljohnbarr added a commit that referenced this issue Oct 31, 2016
@michaeljohnbarr
Drop django 1.4 to 1.7 support (#8)
ad65d30 
- Removed reference to django.db.models.fields.subclassing.SubfieldBase (resolves #7) and conditional import for `django.core.checks`. 
- Removed the `timezone_utils/models.py` and `timezone_utils/migrations`. This means that only Django 1.8+ is now supported.
- Removed support for Python versions < 2.6. The Django 1.6 series was the last to support Python 2.6.
- Added testing support for Django 1.10.
- Coverage fix: calling the super(DateTimeField, self).to_python(value) will convert a naive datetime, so the is_naive condition would never be reached.
- Changed development status from `Beta` to `Production/Stable`.
- Added contributor Alex Kamedov.
- Updated documentation copyright year to 2016.
- Version bump to `0.11`.
- Minor PEP8 changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop django 1.4 to 1.7 support michaeljohnbarr/django-timezone-utils
2 participants
@michaeljohnbarr @djch