Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mxmlSetOpaque, mxmlSetText, and mxmlSetTextf cannot handle existing string pointers #241

Closed
michaelrsweet opened this issue Jan 9, 2019 · 1 comment
Closed

mxmlSetOpaque, mxmlSetText, and mxmlSetTextf cannot handle existing string pointers #241

michaelrsweet opened this issue Jan 9, 2019 · 1 comment
Assignees
@michaelrsweet
Labels
bug Something isn't working
Milestone
v3.0

Comments

@michaelrsweet
Copy link
Owner

If you call mxmlSetXxx with the existing string pointer, it will be freed and then allocated, causing a use-after-free error. Ideally they should detect the "same pointer" case and not bother doing a strdup, and in the case of mxmlSetTextf the string should be freed AFTER the formatting is done.
@michaelrsweet michaelrsweet self-assigned this Jan 9, 2019
@michaelrsweet michaelrsweet added the bug Something isn't working label Jan 9, 2019
@michaelrsweet michaelrsweet added this to the v3.0 milestone Jan 9, 2019
michaelrsweet added a commit that referenced this issue Jan 9, 2019
@michaelrsweet
Fix use-after-free bug in mxmlSet APIs (Issue #241)
0b1caf4
@michaelrsweet
Copy link
Owner Author

[master 0b1caf4] Fix use-after-free bug in mxmlSet APIs (Issue #241)

woollybah added a commit to woollybah/mxml that referenced this issue Jan 11, 2019
@woollybah
Merge pull request #1 from michaelrsweet/master
e5d7c98 
Fix use-after-free bug in mxmlSet APIs (Issue michaelrsweet#241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrsweet michaelrsweet

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.0
Development

No branches or pull requests
1 participant
@michaelrsweet