Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mxmlSetTextf uses wrong strdupf variant #244

Closed
wants to merge 1 commit into from

Conversation

toscha
Copy link

@toscha toscha commented Feb 4, 2019

Hi,
found this little bug here, maybe you're interested.

Regards
Tobias

michaelrsweet added a commit that referenced this pull request Feb 6, 2019
…244)

Use _mxml_vstrdupf function, not _mxml_strdupf.
@michaelrsweet michaelrsweet added bug Something isn't working serious labels Feb 6, 2019
@michaelrsweet michaelrsweet added this to the v3.0 milestone Feb 6, 2019
@michaelrsweet michaelrsweet self-assigned this Feb 6, 2019
@michaelrsweet
Copy link
Owner

Hmm, same bug existed in mxmlSetOpaquef...

[master 1b8f4a2] The mxmlSetOpaquef and mxmlSetTextf functions did not work (Issue #244)

woollybah added a commit to woollybah/mxml that referenced this pull request Feb 12, 2019
* Fix makesrcdist script's archive generation (Issue michaelrsweet#242)

* Add CDATA test of varying lengths, as it looks like we might have yet another
MS C runtime issue with va_copy... :/

* The `mxmlSetOpaquef` and `mxmlSetTextf` functions did not work (Issue michaelrsweet#244)

Use _mxml_vstrdupf function, not _mxml_strdupf.

* Fix _mxml_vsnprintf on Windows (Issue michaelrsweet#245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants