Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and docs #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryanwinchester
Copy link

It's nice to see modern docs and it's nice when docs link to the repo/source code.

@ryanwinchester ryanwinchester force-pushed the rw/deps-and-docs branch 5 times, most recently from 4ff1bcf to 5f60e7a Compare January 7, 2024 02:29
@michalmuskala
Copy link
Owner

Thanks, this looks pretty good.

However, I think the 18.04 runner for github actions has been sunset. Could you update to 20.04?
I recently updated the Jason CI versions, if you need some reference https://github.com/michalmuskala/jason/blob/master/.github/workflows/ci.yml

@ryanwinchester
Copy link
Author

ryanwinchester commented Jan 9, 2024

However, I think the 18.04 runner for github actions has been sunset. Could you update to 20.04?

The table from erlef/setup-beam:

Operating system Erlang/OTP Status
ubuntu-18.04 17 - 25
ubuntu-20.04 20 - 25
ubuntu-22.04 24.2 - 25
windows-2019 21* - 25
windows-2022 21* - 25

means we have to change the elixir/otp combos up too i guess

@michalmuskala
Copy link
Owner

michalmuskala commented Jan 9, 2024

As you can see, the 18.04 jobs are just pending since github no longer provides runners with this os version.
We can start testing from OTP 20 & Elixir 1.4 similar to Jason - older versions are for a long time no longer supported and I'm fine with dropping them from automated tests.

@ryanwinchester
Copy link
Author

As you can see, the 18.04 jobs are just pending since github no longer provides runners with this os version.
We can start testing from OTP 20 & Elixir 1.4 similar to Jason - older versions are for a long time no longer supported and I'm fine with dropping them from automated tests.

Yeah, you're right. Copied the Jason versions.

@ryanwinchester
Copy link
Author

Should I roll back some of the deps updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants