#37 HomeKit uses 1 and 0 for Characteristic.On, must be converted to …

…bool
michbeck100 · Jun 20, 2016 · 2a773af · 2a773af
1 parent 096f6e7
commit 2a773af
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/accessories/switch.coffee b/accessories/switch.coffee
@@ -19,6 +19,9 @@ module.exports = (env) ->
       @addService(service, device.name)
         .getCharacteristic(Characteristic.On)
         .on 'set', (value, callback) =>
+          # HomeKit uses 0 or 1, must be converted to bool
+          if value is 1 then value = true
+          if value is 0 then value = false
           if value is @_state
             env.logger.debug 'value ' + value + ' equals current state of ' +
               device.name + '. Not switching.'

diff --git a/test/switch-test.coffee b/test/switch-test.coffee
@@ -85,3 +85,19 @@ describe "switch", ->
       device._state = null
       device.fireChange()
       assert device._state is null
+
+    it "should handle setting value to 1", ->
+      accessory._state = true
+      accessory.toggle(1)
+      assert device._state is null
+      accessory._state = false
+      accessory.toggle(1)
+      assert device._state is true
+
+    it "should handle setting value to 0", ->
+      accessory._state = false
+      accessory.toggle(0)
+      assert device._state is null
+      accessory._state = true
+      accessory.toggle(0)
+      assert device._state is false