Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #251 and others 'undefined array key' errors. #257

Closed
wants to merge 1 commit into from
Closed

Fix issue #251 and others 'undefined array key' errors. #257

wants to merge 1 commit into from

Conversation

nerun
Copy link

@nerun nerun commented Sep 30, 2023

This is a diff between my changes and the file from current master branch. These lines were added. These additions are harmless to the plugin and has no reasons to not add them:

39a40,46
>         
>         if ( !isset($USERINFO['grps']) ){
>             $USERINFO['grps'] = '';
>         }
>         if ( !isset($INFO['id']) ){
>             $INFO['id'] = '';
>         }
72a80,82
>         if ( !isset($JSINFO['move_renameokay']) ){
>             $JSINFO['move_renameokay'] = '';
>         }

Issue #251

@michitux
Copy link
Owner

michitux commented May 7, 2024

It doesn't seem like a good idea to just write to these global variables, in particular as some of them shouldn't be of type string. Instead, the code should use proper ways to test if the array key exists before using it. I've just pushed a commit that fixes the remaining problems (one was already fixed).

@michitux michitux closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants