Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pgl_backend_s3: add option for no_verify_ssl #638

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

InsOpDe
Copy link

@InsOpDe InsOpDe commented Oct 25, 2023

As a User I want to be able to ignore SSL Verification (in case the authority is unknown f.e.) so that I can still connect without getting x509 certificate errors.

This PR adds a checkbox where the user can check this option:

image

This PR also adds the option to use boolean checkboxes with labels via the Formbuilder.

I did not add any translations as the other fields didn't have any as well. I also am missing a contribution Guide

@mickael-kerjean
Copy link
Owner

The frontend part of the code you made a change to is currently being rewritten from scratch as we're moving away from React to Vanilla JS. What that means is we can't allow code changes in the frontend side as what you had to change is gonna disappear in the next few months.

I will keep this PR open as we should be able to merge this minus the frontend change to enable that same functionality once the entire migration is done.

@InsOpDe
Copy link
Author

InsOpDe commented Nov 2, 2023

oh snap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants