fix: disallow # in domain (#259)

micke · Nov 3, 2024 · 1643323 · 1643323
1 parent 0af589f
commit 1643323
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/valid_email2/address.rb b/lib/valid_email2/address.rb
@@ -9,7 +9,7 @@ module ValidEmail2
   class Address
     attr_accessor :address
 
-    PROHIBITED_DOMAIN_CHARACTERS_REGEX = /[+!_\/\s'`]/
+    PROHIBITED_DOMAIN_CHARACTERS_REGEX = /[+!_\/\s'#`]/
     DEFAULT_RECIPIENT_DELIMITER = '+'
     DOT_DELIMITER = '.'
 

diff --git a/spec/valid_email2_spec.rb b/spec/valid_email2_spec.rb
@@ -163,6 +163,11 @@ class TestUserMultiple < TestModel
       user = TestUser.new(email: "foo@example.com ")
       expect(user.valid?).to be_falsey
     end
+
+    it "is invalid if domain contains #" do
+      user = TestUser.new(email: "foo@example.com#")
+      expect(user.valid?).to be_falsey
+    end
   end
 
   describe "with disposable validation" do