Fix test that tests that domain is present and don't allow domains to…

… start with a dot, Fixes #63
micke · Mar 16, 2017 · c3948da · c3948da
1 parent 9d75a6d
commit c3948da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/valid_email2/address.rb b/lib/valid_email2/address.rb
@@ -22,8 +22,8 @@ def valid?
 
       if address.domain && address.address == @raw_address
         domain = address.domain
-        # Valid address needs to have a dot in the domain
-        !!domain.match(/\./) && !domain.match(/\.{2,}/)
+        # Valid address needs to have a dot in the domain but not start with a dot
+        !!domain.match(/\./) && !domain.match(/\.{2,}/) && !domain.match(/^\./)
       else
         false
       end

diff --git a/spec/valid_email2_spec.rb b/spec/valid_email2_spec.rb
@@ -25,7 +25,7 @@ class TestUserDisallowBlacklisted < TestModel
     end
 
     it "should not be valid when domain is missing" do
-      user = TestUser.new(email: "foo")
+      user = TestUser.new(email: "foo@.com")
       expect(user.valid?).to be_falsey
     end