Ability to check for disposable domain without MX server check #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may want the ability to only check for a disposable domain, without an additional check for the MX server - there's a trade off between the value of the extra check for the MX server and the time saved by not making that check (because of the call to the DNS resolver).
Currently, you can only get this functionality by doing something like this:
My proposed PR would keep the
disposable?
method but also have separate methods fordisposable_domain?
anddisposable_mx_server?
. You can also pass indisposable_domain: true
into theoptions
hash if you don't want to check themx_server
during thedisposable
check.