Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that locals do not include dots. Fixes #36 #146

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Validate that locals do not include dots. Fixes #36 #146

merged 1 commit into from
Mar 18, 2020

Conversation

pjmartorell
Copy link
Contributor

  • Resolves Dots in GMail addresses #36
  • Add disallow_dotted option to enable validation of locals with dots
  • Add dotted? method to check if a local includes a dot

@firefart
Copy link

Shouldn't we add this case to subaddressed? too?

@pjmartorell
Copy link
Contributor Author

@firefart having it in a separate option allows more flexibility and does not create a breaking change with the current behavior

@micke micke merged commit de241c3 into micke:master Mar 18, 2020
@micke
Copy link
Owner

micke commented Mar 18, 2020

Thanks @pjmartorell
I was under the impression that if you register a gmail address with a dot in it, that you don't get the undotted version too.

@micke
Copy link
Owner

micke commented Mar 18, 2020

I just pushed version 3.2.0 to rubygems!

@pjmartorell pjmartorell deleted the feature/disallow-dots branch March 18, 2020 17:32
@pjmartorell
Copy link
Contributor Author

thanks, @micke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dots in GMail addresses
3 participants