Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelisted disposable domains #167

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

vdolbilov
Copy link
Contributor

@vdolbilov vdolbilov commented Oct 8, 2020

Hello,

I added a config option for disposable_domain_with_whitelist which allows for checking only disposable_domain? against the whitelist without checking for MX servers.

Also fixed a spec that was incorrect - is valid if the domain is disposable but in the whitelist was incorrectly passing that user.valid? was falsy due to ValidEmail2.whitelist being cached to an empty set.

I used instance_variable_set in the spec to avoid having to change valid_email2.rb to allow whitelist setting, I can do that instead if you prefer.

@micke micke merged commit c0405c9 into micke:master Oct 30, 2020
@micke
Copy link
Owner

micke commented Oct 30, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants