Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added a config option for
disposable_domain_with_whitelist
which allows for checking onlydisposable_domain?
against the whitelist without checking for MX servers.Also fixed a spec that was incorrect -
is valid if the domain is disposable but in the whitelist
was incorrectly passing thatuser.valid?
wasfalsy
due toValidEmail2.whitelist
being cached to an empty set.I used
instance_variable_set
in the spec to avoid having to changevalid_email2.rb
to allow whitelist setting, I can do that instead if you prefer.