Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 34 #35

Closed
wants to merge 3 commits into from
Closed

Issue 34 #35

wants to merge 3 commits into from

Conversation

mfly
Copy link

@mfly mfly commented Oct 8, 2015

Implementation of suggestions from:
#34

@micke
Copy link
Owner

micke commented Oct 9, 2015

Thanks, i really appreciate your contribution but i decided to solve this in a different way.

I don't feel like a whitelist fits in valid_email2 as it's only purpose is to block disposable email addresses, i would rather make sure that the provider list doesn't include any legit email providers.

So instead of adding a whitelist to valid_email2's core i just added a simple whitelist to the pull_mailchecker_emails script so that we can filter out false positives there.

@micke micke closed this Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants