Remove disposable domains that were removed from mailchecker #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGRibreau/mailchecker@17af0c5 126.com 163.com sina.com sohu.com vip.163.com vip.qq.com vip.sina.com FGRibreau/mailchecker@fa7696d disposableemailaddresses:emailmiser.com FGRibreau/mailchecker@df525b9 yeah.net
|
Thanks! |
|
I've release 1.2.15 to rubygems with this PR merged. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran your disposable domain database against our own and found many false positives for Chinese email domains. I dug and found they'd been removed from mailchecker. So I modified and ran the update script locally to not keep the existing domains, filtered to just removed domains, and then searched the mailchecker history (with
git log -p -S domain -- list.json) to verify they had been removed and where.FGRibreau/mailchecker@17af0c5
126.com
163.com
sina.com
sohu.com
vip.163.com
vip.qq.com
vip.sina.com
FGRibreau/mailchecker@fa7696d
disposableemailaddresses:emailmiser.com
FGRibreau/mailchecker@df525b9
yeah.net