Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte 4, Vite 5, Jest->Vitest #427

Merged
merged 1 commit into from
Dec 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
* SPDX-License-Identifier: MIT
*/
module.exports = {
root: true,
parser: '@typescript-eslint/parser',
extends: [
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'plugin:@typescript-eslint/recommended-requiring-type-checking',
'plugin:svelte/recommended',
],
parserOptions: {
ecmaVersion: 2020,
Expand All @@ -18,28 +20,24 @@ module.exports = {
extraFileExtensions: ['.svelte'],
},
env: {
es6: true,
browser: true,
es6: true,
node: true,
},
overrides: [
{
files: ['*.svelte'],
processor: 'svelte3/svelte3',
parser: 'svelte-eslint-parser',
parserOptions: {
parser: '@typescript-eslint/parser',
},
},
],
settings: {
'svelte3/typescript': require('typescript'),
// ignore style tags in Svelte because of Tailwind CSS
// See https://github.com/sveltejs/eslint-plugin-svelte3/issues/70
'svelte3/ignore-styles': () => true,
},
globals: {
NodeJS: true,
process: true,
},
plugins: ['svelte3', '@typescript-eslint'],
ignorePatterns: ['node_modules', 'svelte.config.js', '.eslintrc.cjs', "babel.config.cjs", "jest.config.js"],
plugins: ['@typescript-eslint'],
ignorePatterns: [
'node_modules',
'svelte.config.js',
'.eslintrc.cjs',
'babel.config.cjs',
],
};
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ permissions:
contents: read

jobs:
Jest:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/production.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ permissions:
contents: read

jobs:
Jest:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Please note we have a code of conduct, please follow it in all your interactions

## Pull Request Process

1. Ensure any install or build dependencies are removed and the tests using `jest` are running successfully.
1. Ensure any install or build dependencies are removed and the tests using `npm run test` are running successfully.
2. Update the README.md with details of changes to the interface, this includes new environment
variables and useful file locations, if applicable.
3. Increase the version numbers in any examples files and the README.md to the new version that this
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ We recommend starting here.

### ```npm test```

Runs the test suite. Tests are driven by the framework [Jest](https://jestjs.io/). Runs all tests inside the folder `./src/__tests__/`.
Runs the test suite. Tests are driven by the framework [Vitest](https://vitest.dev/). Runs all tests inside the folder `./src/__tests__/`.

If you do not plan to contribute to the project, you may safely ignore this.

Expand Down
Loading