Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mocking with different kinds of artifacts & Contract testing of REST APis (OPEN_API_SCHEMA) #1

Merged
merged 8 commits into from
Nov 20, 2024

Conversation

SebastienDegodez
Copy link
Contributor

@SebastienDegodez SebastienDegodez commented Nov 9, 2024

Description

The purpose of this PR is to submit an initial version of Microcks with TestContainers. This first version brings:

  • Mocking of REST APIs, SOAP WebServices, GraphQL APIs and gRPC APIs. using different kinds of artifacts
  • Contract testing of REST APIs using OPEN_API_SCHEMA.

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run dotnet test and ensure you have test coverage for the lines you are introducing
  • run dotnet husky run and fix any issues that you have introduced

Reviewer

  • Label as either feature, fix, documentation, enhancement, maintenance or breaking

@SebastienDegodez SebastienDegodez changed the title Mocking using different kinds of artifacts & Contract testing of REST APis (OPEN_API_SCHEMA) Mocking with different kinds of artifacts & Contract testing of REST APis (OPEN_API_SCHEMA) Nov 9, 2024
@SebastienDegodez SebastienDegodez force-pushed the main branch 3 times, most recently from 95106dd to 38adb07 Compare November 11, 2024 10:38
@SebastienDegodez SebastienDegodez changed the title Mocking with different kinds of artifacts & Contract testing of REST APis (OPEN_API_SCHEMA) feat: Mocking with different kinds of artifacts & Contract testing of REST APis (OPEN_API_SCHEMA) Nov 11, 2024
@SebastienDegodez SebastienDegodez force-pushed the main branch 2 times, most recently from b7c57d8 to 32ad679 Compare November 17, 2024 20:38
Signed-off-by: Sébastien DEGODEZ <sebastien.degodez@gmail.com>
@SebastienDegodez SebastienDegodez force-pushed the main branch 5 times, most recently from 91b916b to 50eb278 Compare November 17, 2024 21:29
@SebastienDegodez
Copy link
Contributor Author

@SebastienDegodez SebastienDegodez marked this pull request as ready for review November 17, 2024 21:32
.editorconfig Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SebastienDegodez!

Thanks so much for the contribution. I commented and asked some questions along the files but it's much more for my own understanding than requests for changes.

One important thing is related to adding a header in each .cs file (like this example in java) to explicitely remind the Apache 2.0 License and transfer the copyright of your work to the project - or more precisely the Cloud Native Computing Foundation (CNCF) that owns the IP. We can add this header later on but we actually need your formal agreement to do so. Please confirm here if you agree or not on these.

Thanks again! Looking forward for merging this and having our first Nuget release!

@SebastienDegodez
Copy link
Contributor Author

Hey @SebastienDegodez!

Thanks so much for the contribution. I commented and asked some questions along the files but it's much more for my own understanding than requests for changes.

One important thing is related to adding a header in each .cs file (like this example in java) to explicitely remind the Apache 2.0 License and transfer the copyright of your work to the project - or more precisely the Cloud Native Computing Foundation (CNCF) that owns the IP. We can add this header later on but we actually need your formal agreement to do so. Please confirm here if you agree or not on these.

Thanks again! Looking forward for merging this and having our first Nuget release!

I will add in the config editor, and in all files

This version contains the following features:
- Mocking of REST APIs, SOAP WebServices, GraphQL APIs and gRPC APIs. using different kinds of artifacts
- Contract testing of REST APIs using OPEN_API_SCHEMA.

Signed-off-by: Sébastien DEGODEZ <sebastien.degodez@gmail.com>
Signed-off-by: Sébastien DEGODEZ <sebastien.degodez@gmail.com>
Signed-off-by: Sébastien DEGODEZ <sebastien.degodez@gmail.com>
Signed-off-by: Sébastien DEGODEZ <sebastien.degodez@gmail.com>
Signed-off-by: Sébastien DEGODEZ <sebastien.degodez@gmail.com>
@lbroudoux lbroudoux added the kind/enhancement Enhancement of existing feature label Nov 19, 2024
- Add license header to all source files and in editorconfig.
- Update README to include '--version' option in the dotnet add package command.
- Update Release Drafter configuration to reflect microcks-testcontainer-java release.

Signed-off-by: Sébastien DEGODEZ <sebastien.degodez@gmail.com>
Signed-off-by: Sébastien DEGODEZ <sebastien.degodez@gmail.com>
Copy link
Member

@lbroudoux lbroudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're all good. Thanks again for the great work! Now, let's merge this!

@lbroudoux lbroudoux merged commit 0436e70 into microcks:main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants