WIP: Update URLs in testcases #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In what ways is this change different from those in #112? Based on the linked chat log, it looks like there may be a different consensus on trailing slashes than there was when I opened 112? I'd be in favor of that! 😄 |
|
I didn't even know that was open @jgarber623 - I think I'll still keep this in a WIP state (currently working on https://gitlab.com/maxburon/microformats-parser/-/merge_requests/2 at the moment) but when I get that completed and I still run into these issues, I'll aim to revisit :) |
|
Yeah, I just ran into another URL that's mentioned in #112 so I'll close this in favor of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, check https://chat.indieweb.org/microformats/2022-02-03#t1643908804343300