Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ResidentKeyRequirement #2022

Closed
relan opened this issue Sep 5, 2023 · 5 comments
Closed

Implement ResidentKeyRequirement #2022

relan opened this issue Sep 5, 2023 · 5 comments

Comments

@relan
Copy link

relan commented Sep 5, 2023

Is your feature request related to a problem? Please describe.
org.microg.gms:play-services-fido does not have ResidentKeyRequirement. It's needed to replace com.google.android.gms:play-services-fido in Firefox. See the use in GeckoView.

Describe the solution you'd like
Add ResidentKeyRequirement and related stuff (including builder method).

Describe alternatives you've considered
Made a patch to remove ResidentKeyRequirement but didn't have a chance to test it:

@@ -192,16 +191,13 @@
     final String residentKey = authenticatorSelection.getString("residentKey", "");
     if (residentKey.equals("required")) {
       selBuild
-          .setRequireResidentKey(true)
-          .setResidentKeyRequirement(ResidentKeyRequirement.RESIDENT_KEY_REQUIRED);
+          .setRequireResidentKey(true);
     } else if (residentKey.equals("preferred")) {
       selBuild
-          .setRequireResidentKey(false)
-          .setResidentKeyRequirement(ResidentKeyRequirement.RESIDENT_KEY_PREFERRED);
+          .setRequireResidentKey(false);
     } else if (residentKey.equals("discouraged")) {
       selBuild
-          .setRequireResidentKey(false)
-          .setResidentKeyRequirement(ResidentKeyRequirement.RESIDENT_KEY_DISCOURAGED);
+          .setRequireResidentKey(false);
     }
     final AuthenticatorSelectionCriteria sel = selBuild.build();
 
@mar-v-in mar-v-in changed the title [FIDO] Implement ResidentKeyRequirement Implement ResidentKeyRequirement Sep 5, 2023
@mar-v-in
Copy link
Member

mar-v-in commented Sep 6, 2023

This was added to the Play Services Fido API by Google earlier this year (along with a few other things) and thus isn't present in the implementation of microG yet. Will add soon.

@mar-v-in mar-v-in added this to the 0.2.29 milestone Sep 6, 2023
mar-v-in added a commit that referenced this issue Sep 11, 2023
Also handle empty strings from apps as none.

Fixes #2021, #2022
@ale5000-git
Copy link
Member

ale5000-git commented Sep 12, 2023

@relan
Hi,
is it possible to have a compiled build of Firefox with org.microg.gms:play-services-fido to test?

@mar-v-in
Copy link
Member

Nightly is also updated with those changes.

@ale5000-git
Copy link
Member

Good, thanks :)

@relan
Copy link
Author

relan commented Sep 13, 2023

GeckoView builds fine with org.microg.gms:play-services-fido compiled from 666361a. Thanks!

@relan relan closed this as completed Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants