Update Polish translations #1876
Conversation
|
|
Oh, I see this PR is based on old sources, I might again work on this PR and localize another files that I haven't looked at yet. I might also resolve conflicts and sync my fork with the upstream for some time. |
|
I hope I've caught all values now, I used this command to find all find -type d -name "values"In contrast to PR #1377, this PR also contains recent FIDO and has been made from scratch, so there might be some slight differences within the used words, although meaning should be similar (I've tried to picked synonyms that sound more natural in Polish rather these words which look and sound more closely to the original ones in For tests with prebuilt app, I dunno… maybe I'll try build microG from sources and check how that works either in Android emulator or on real device if I'll find some time for that. |
|
play-services-nearby/core/src/main/res/values-pl/strings.xml |
|
@Wojtaz0w thanks for noticing that, I translated it a bit differently (I used "dla" instead of "w celu" and added "poprzez" pronoun, which I think makes it to look and sound more naturally – not sure if you agree with that, I guess it might be more a personal thing). I've also made you a co-author of this commit, I dunno if I would notice that string without you, so I wanted to give you some attribution as well 🙂️. I also want fix quotes in current Polish microG translations (in |
|
Also check microg/UnifiedNlp#249. |
mar-v-in
force-pushed
the
master
branch
4 times, most recently
from
ae17355
to
8078073
Compare
SpacingBat3
force-pushed
the
master
branch
2 times, most recently
from
622f221
to
3a671f6
Compare
- Add missing strings. - Sync license comment in `strings.xml` in `core`. - Minior tweaks.
Replace tabs with spaces.
Co-authored-by: Wojtaz0w <104674625+Wojtaz0w@users.noreply.github.com>
The double quotes are more appropriate for Polish language and should be preferred over English upper single quotes.
Localize `values` for new location stack.
|
With |
|
Line 16 in commit d6a3f37 (new location settings translation) is partially translated, also "Mozilly" should be replaced with "Mozilli" (według mnie w dopełniaczu powinno mówić się mozilli a nie mozilly) (wiem że ss z 2006 ale język nie zmienia się tak szybko 😉) |
Sounds right to me! Funilly enough, I've been checking mozilla.org for tips on localization and somehow still didn't payed attention to how it is there. Thanks a lot again! |
• Translate parts of `strings.xml` that weren't fully translated before. • Typo fixes and improvements. Co-authored-by: Wojtaz0w <104674625+Wojtaz0w@users.noreply.github.com>
|
I've updated translations according to your comment, I think nothing else is going to be improved for now and this PR is finally ready to be merged. |
SpacingBat3
force-pushed
the
upstream-merge
branch
from
5d6e57c
to
94d6e7f
Compare
|
OK, I've updated translation for new strings, possibly I'll give it a try and build microG (again) to see if I haven't left anything (+ it's going to be interesting to test how new localization API works). I guess it's now ready for reviews (especially from microG maintainers)… |
|
I've set up Actions to build and sign GmsCore in my repo. You can use that to download prebuilt binaries for testing. Take a note those are obviously signed with different key, so you won't be able to update it over existing microG binaries, at least without disabling signature verification when installing apps in Android. |
|
@mar-v-in Pinging in case this PR hasn't been noticed or sth. Feel free to take your time, though, I saw a lot of people were pinging you already and I don't want to give any additional pressure to that. Also I believe I've translated everything I could to Polish for now. |
|
Looks like microG is now using Weblate and will accept translations that way (yay!), but I suppose the current work I did stays in conflict with what's in Weblate and most likely won't be accepted (boo?), so I'll probably be closing this PR and eventually contributing the translations via Weblate (it doesn't look like Polish translations are as complete in Weblate as here on my repo, at least just by comparing the conflicting files). Also, since I've been working on a CI/CD, I might also do some effort to make it upstreamed and made more properly (possibly to not to rely on any external actions). |
|
I've published most of my changes to Weblate, so the translations should now be complete. I suppose this makes this PR stale and it is safe to finally close it. |
|
Guess that pushing translations to weblate finally makes the microG creator notice them... TYSM for hard work. |
Things in scope of this PR:
I localized some recently added strings to microG to Polish.
play-services-core -> strings.xml.I removed full license notice and replaced it with the newer ones from original
valuesinstrings.xml(onlyplay-services-core, I believe others had them OK, at least when comparing with originalvalues).Some grammar fixes, alternative localizations that I find more accurate to the original or more appropriate for the language etc.
Things currently not in scope for this PR:
Since most of these weren't localized a long time ago, I'm not sure if it is desired to localize components name, considering most of them are not localized for any language.
Nightly builds:
There are nightly builds available, both unsigned and signed by GitHub Actions using key generated by me, distributed as artifacts of following actions runs. Note: you need to sign in to GitHub in order to download artifacts.