Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meter for process CPU time #4499

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Add Meter for process CPU time #4499

merged 2 commits into from
Feb 29, 2024

Conversation

simonzn
Copy link
Contributor

@simonzn simonzn commented Dec 19, 2023

Closes #4498

@pivotal-cla
Copy link

@simonzn Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@simonzn Thank you for signing the Contributor License Agreement!

@marcingrzejszczak
Copy link
Contributor

Can you please fix the build? I think there are issues with checkstyle

@simonzn
Copy link
Contributor Author

simonzn commented Dec 28, 2023

It seems the checkstyle error was fixed on main; rebased. Afterwards tests failed with a ClassCastException - fixed as well.

@jonatan-ivanov jonatan-ivanov changed the title Adds a meter for the cumulated CPU time Add Meter for process CPU time Feb 29, 2024
@jonatan-ivanov jonatan-ivanov merged commit 8604662 into micrometer-metrics:main Feb 29, 2024
6 checks passed
@jonatan-ivanov
Copy link
Member

Thank you for the contribution!
I rebased the PR on top of main, polished a bit, added a few more asserts and merged in.
It should be available as a snapshot in a few minutes and go out with our next milestone release next month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Meter for process CPU time
4 participants