Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document no support for meta-annotations with @Timed/@Counted #5737

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Dec 9, 2024

This PR documents that meta-annotations with @Timed or @Counted are not supported in their respective aspect.

See gh-5657

Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This should go to 1.12.x since it's applicable to all maintenance lines.

@shakuzen shakuzen added the doc-update A documentation update label Dec 10, 2024
@shakuzen shakuzen modified the milestones: 1.13.9, 1.13.x Dec 10, 2024
@izeye izeye changed the base branch from main to 1.12.x December 10, 2024 13:49
@izeye
Copy link
Contributor Author

izeye commented Dec 10, 2024

@shakuzen Thanks for the feedback!

I rebased this onto the 1.12.x branch and changed its target branch to the 1.12.x branch.

@jonatan-ivanov jonatan-ivanov modified the milestones: 1.13.x, 1.13.10 Dec 10, 2024
@jonatan-ivanov jonatan-ivanov merged commit a15f69c into micrometer-metrics:1.12.x Dec 10, 2024
6 checks passed
@jonatan-ivanov
Copy link
Member

Thank you!

@izeye izeye deleted the gh-5657 branch December 10, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-update A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants