Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OtelSpan public instead of package-private #808

Closed
ThomasVitale opened this issue Aug 13, 2024 · 1 comment · Fixed by #809
Closed

Make OtelSpan public instead of package-private #808

ThomasVitale opened this issue Aug 13, 2024 · 1 comment · Fixed by #809
Labels
enhancement New feature or request
Milestone
1.4.0-RC1

Comments

@ThomasVitale
Copy link
Contributor

ThomasVitale commented Aug 13, 2024 •
edited
Loading

The OtelSpan class implementing the Span interface is package private, which makes it not possible to act on the underlying OpenTelemetry Span object (unless Reflection is used). One use case for this would be to add structured events to a Span (necessary until micrometer-metrics/micrometer#5238 is implemented).

That is different from the BraveSpan class, which is set as public.

Is it possible to make OtelSpan public in the 1.3.x release line?
ThomasVitale added a commit to ThomasVitale/micrometer-tracing that referenced this issue Aug 13, 2024
@ThomasVitale
Make OtelSpan publicly accessible
e8d8a15 
Fixes micrometer-metricsgh-808
@ThomasVitale ThomasVitale mentioned this issue Aug 13, 2024
Merged
@ThomasVitale
Copy link
Contributor Author

In case the feature request is accepted, I drafted a PR to align the visibility of OtelSpan to the one of BridgeSpan. #809

@ThomasVitale ThomasVitale mentioned this issue Aug 17, 2024
Closed
ThomasVitale added a commit to ThomasVitale/micrometer-tracing that referenced this issue Sep 19, 2024
@ThomasVitale
Make OtelSpan publicly accessible
6569f1b 
Fixes micrometer-metricsgh-808

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
@jonatan-ivanov jonatan-ivanov added the enhancement New feature or request label Sep 19, 2024
@jonatan-ivanov jonatan-ivanov added this to the 1.4.0-RC1 milestone Sep 19, 2024
jonatan-ivanov pushed a commit that referenced this issue Sep 19, 2024
@ThomasVitale
Make OtelSpan publicly accessible (#809)
65e2c9e 
Fixes gh-808

Signed-off-by: Thomas Vitale <ThomasVitale@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0-RC1
Development

Successfully merging a pull request may close this issue.

Make OtelSpan publicly accessible ThomasVitale/micrometer-tracing
2 participants
@jonatan-ivanov @ThomasVitale