Sender and receiver propagating observation handlers #36

marcingrzejszczak · 2022-07-14T17:35:49Z

Prerequisite - https://github.com/micrometer-metrics/micrometer/pull/3293/files

remove any usaes of http handlers

sonatype-lift · 2022-07-18T12:24:17Z

...ation-test/src/main/java/io/micrometer/tracing/test/reporter/inmemory/InMemoryOtelSetup.java

@@ -366,12 +366,10 @@ private static Consumer<OtelBuildingBlocks> closingFunction() {
        @SuppressWarnings("rawtypes")
        private static ObservationHandler<Observation.Context> tracingHandlers(OtelBuildingBlocks otelBuildingBlocks) {
            OtelTracer tracer = otelBuildingBlocks.otelTracer;
-            HttpServerHandler httpServerHandler = otelBuildingBlocks.httpServerHandler;
-            HttpClientHandler httpClientHandler = otelBuildingBlocks.httpClientHandler;

            LinkedList<ObservationHandler<? extends Observation.Context>> handlers = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-18T12:28:39Z

...tion-test/src/main/java/io/micrometer/tracing/test/reporter/inmemory/InMemoryBraveSetup.java

@@ -337,11 +337,9 @@ private static Consumer<BraveBuildingBlocks> closingFunction() {
        @SuppressWarnings("rawtypes")
        private static ObservationHandler<Observation.Context> tracingHandlers(BraveBuildingBlocks braveBuildingBlocks) {
            Tracer tracer = braveBuildingBlocks.tracer;
-            HttpServerHandler httpServerHandler = braveBuildingBlocks.httpServerHandler;
-            HttpClientHandler httpClientHandler = braveBuildingBlocks.httpClientHandler;
            LinkedList<ObservationHandler<? extends Observation.Context>> handlers = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-18T12:28:44Z

...ion-test/src/main/java/io/micrometer/tracing/test/reporter/wavefront/WavefrontOtelSetup.java

@@ -450,11 +450,10 @@ private static Consumer<OtelBuildingBlocks> closingFunction() {
        @SuppressWarnings("rawtypes")
        private static ObservationHandler<Observation.Context> tracingHandlers(OtelBuildingBlocks otelBuildingBlocks) {
            OtelTracer tracer = otelBuildingBlocks.otelTracer;
-            HttpServerHandler httpServerHandler = otelBuildingBlocks.httpServerHandler;
-            HttpClientHandler httpClientHandler = otelBuildingBlocks.httpClientHandler;
+
            LinkedList<ObservationHandler<? extends Observation.Context>> handlers = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-18T12:28:51Z

...tegration-test/src/main/java/io/micrometer/tracing/test/reporter/zipkin/ZipkinOtelSetup.java

@@ -457,11 +457,10 @@ private static Consumer<OtelBuildingBlocks> closingFunction() {
        @SuppressWarnings("rawtypes")
        private static ObservationHandler<Observation.Context> tracingHandlers(OtelBuildingBlocks otelBuildingBlocks) {
            OtelTracer tracer = otelBuildingBlocks.otelTracer;
-            HttpServerHandler httpServerHandler = otelBuildingBlocks.httpServerHandler;
-            HttpClientHandler httpClientHandler = otelBuildingBlocks.httpClientHandler;
+
            LinkedList<ObservationHandler<? extends Observation.Context>> handlers = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-18T12:28:52Z

...on-test/src/main/java/io/micrometer/tracing/test/reporter/wavefront/WavefrontBraveSetup.java

@@ -419,11 +419,10 @@ private static Consumer<BraveBuildingBlocks> closingFunction() {
        @SuppressWarnings("rawtypes")
        private static ObservationHandler<Observation.Context> tracingHandlers(BraveBuildingBlocks braveBuildingBlocks) {
            Tracer tracer = braveBuildingBlocks.tracer;
-            HttpServerHandler httpServerHandler = braveBuildingBlocks.httpServerHandler;
-            HttpClientHandler httpClientHandler = braveBuildingBlocks.httpClientHandler;
+
            LinkedList<ObservationHandler<? extends Observation.Context>> handlers = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2022-07-18T12:29:02Z

...egration-test/src/main/java/io/micrometer/tracing/test/reporter/zipkin/ZipkinBraveSetup.java

@@ -418,11 +418,10 @@ private static Consumer<BraveBuildingBlocks> closingFunction() {
        @SuppressWarnings("rawtypes")
        private static ObservationHandler<Observation.Context> tracingHandlers(BraveBuildingBlocks braveBuildingBlocks) {
            Tracer tracer = braveBuildingBlocks.tracer;
-            HttpServerHandler httpServerHandler = braveBuildingBlocks.httpServerHandler;
-            HttpClientHandler httpClientHandler = braveBuildingBlocks.httpClientHandler;
+
            LinkedList<ObservationHandler<? extends Observation.Context>> handlers = new LinkedList<>();


JdkObsolete: It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.

Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.

When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.

Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

marcingrzejszczak added the enhancement New feature or request label Jul 14, 2022

marcingrzejszczak force-pushed the receiverAndSenderContexts branch 2 times, most recently from ed62e8d to d76b00f Compare July 15, 2022 13:18

marcingrzejszczak added the breaking-change label Jul 15, 2022

marcingrzejszczak added this to the 1.0.0-M7 milestone Jul 15, 2022

marcingrzejszczak mentioned this pull request Jul 15, 2022

Uses the new receiver and sender contexts reactor/reactor-netty#2389

Merged

2 tasks

jonatan-ivanov approved these changes Jul 15, 2022

View reviewed changes

marcingrzejszczak added 6 commits July 18, 2022 10:06

Sender and receiver propagating observation handlers

de1ec3a

Removes all the http related code

189427f

Moved Http* related code to Tracing + removed the HttpHandlers

781aae9

Fixed compilation issues

81871ee

Fixed wrong generics

0478643

Polish

01a5249

marcingrzejszczak mentioned this pull request Jul 18, 2022

Migrates to sender and receiver propagation handlers spring-projects/spring-boot#31783

Closed

2 tasks

marcingrzejszczak force-pushed the receiverAndSenderContexts branch from 792057d to b3fff55 Compare July 18, 2022 12:19

sonatype-lift bot reviewed Jul 18, 2022

View reviewed changes

Set span kind on the sender span

b171042

marcingrzejszczak force-pushed the receiverAndSenderContexts branch from b3fff55 to b171042 Compare July 18, 2022 12:24

sonatype-lift bot reviewed Jul 18, 2022

View reviewed changes

marcingrzejszczak merged commit 128e288 into main Jul 18, 2022

marcingrzejszczak deleted the receiverAndSenderContexts branch July 18, 2022 12:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sender and receiver propagating observation handlers #36

Sender and receiver propagating observation handlers #36

marcingrzejszczak commented Jul 14, 2022 •

edited

Loading

sonatype-lift bot Jul 18, 2022

sonatype-lift bot Jul 18, 2022

sonatype-lift bot Jul 18, 2022

sonatype-lift bot Jul 18, 2022

sonatype-lift bot Jul 18, 2022

sonatype-lift bot Jul 18, 2022

Sender and receiver propagating observation handlers #36

Sender and receiver propagating observation handlers #36

Conversation

marcingrzejszczak commented Jul 14, 2022 • edited Loading

sonatype-lift bot Jul 18, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 18, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 18, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 18, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 18, 2022

Choose a reason for hiding this comment

sonatype-lift bot Jul 18, 2022

Choose a reason for hiding this comment

marcingrzejszczak commented Jul 14, 2022 •

edited

Loading