Making Context-Propagation library a mandatory dependency #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
approved these changes
Jul 15, 2022
Without this being mandatory things like ObservationThreadLocalAccessor from Micrometer Core will not be applicable In general without Context Propagation Tracing will not work properly
marcingrzejszczak
force-pushed
the
contextPropagationMandatory
branch
from
dac1c30
to
e926eec
Compare
shakuzen
reviewed
Jul 19, 2022
| @@ -4,6 +4,7 @@ plugins { | |||
|
|
|||
| dependencies { | |||
| api 'io.micrometer:micrometer-observation' | |||
| api 'io.micrometer:context-propagation' | |||
There was a problem hiding this comment.
Is it needed as api or implementation? In other words, do users of micrometer tracing need context-propagation on the classpath when compiling or only at runtime? If context-propagation types are not in any of tracing's API that users would compile against, then it can be implementation instead, I think.
There was a problem hiding this comment.
ok I'll change it to implementation then
marcingrzejszczak
added a commit
that referenced
this pull request
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this being mandatory things like ObservationThreadLocalAccessor from Micrometer Core will not be applicable
In general without Context Propagation Tracing will not work properly