Use epoch milli to check span start/stop #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change,
TracerAssert#onlySpan
randomly failed.This was because it had followings to check a span has started/stopped.
The
getNano()
could return0
for validInstant
.For example:
Instead of using
getNano()
, this PR changes to constantly usetoEpochMilli() > 0
to check whether the span has started or stopped.Instant.ofEpochMilli(0).toEpochMilli()
returns0
whereasInstant.ofEpochMilli(10).toEpochMilli()
returns10
.