Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honors parent trace context even if there was no span #722

Merged
merged 1 commit into from
May 22, 2024
Merged

Honors parent trace context even if there was no span #722

merged 1 commit into from
May 22, 2024

Conversation

marcingrzejszczak
Copy link
Contributor

  • without this change, for OTel, we always look at spans when talking about setting a parent on a span. However it is completely valid to pass just trace context data (span id, trace id, sampling flag etc.)
  • with this change, for OTel, we honor that setting and will look at both span and span trace context

fixes gh-698

@marcingrzejszczak
Honors parent trace context even if there was no span
9c62b94 
- without this change, for OTel, we always look at spans when talking about setting a parent on a span. However it is completely valid to pass just trace context data (span id, trace id, sampling flag etc.)
- with this change, for OTel, we honor that setting and will look at both span and span trace context

fixes gh-698
@marcingrzejszczak marcingrzejszczak added this to the 1.2.7 milestone May 21, 2024
@jonatan-ivanov jonatan-ivanov linked an issue May 21, 2024 that may be closed by this pull request
OtelTracer does not set parent context when explicitly specified #698
Closed
@jonatan-ivanov jonatan-ivanov removed this from the 1.2.7 milestone May 21, 2024
@marcingrzejszczak marcingrzejszczak merged commit fedae62 into 1.2.x May 22, 2024
6 checks passed
@marcingrzejszczak marcingrzejszczak deleted the issues_#698_otel_parent_not_set branch May 22, 2024 12:52
marcingrzejszczak added a commit that referenced this pull request May 24, 2024
@marcingrzejszczak
Honors parent trace context even if there was no span (#722)
ed9960d 
- without this change, for OTel, we always look at spans when talking about setting a parent on a span. However it is completely valid to pass just trace context data (span id, trace id, sampling flag etc.)
- with this change, for OTel, we honor that setting and will look at both span and span trace context

fixes gh-698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatan-ivanov jonatan-ivanov jonatan-ivanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OtelTracer does not set parent context when explicitly specified
2 participants
@marcingrzejszczak @jonatan-ivanov