Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nullable
annotations to methods and fields in micrometer-tracing-bridges directories.@Nullable
annotations toTraceContext.sampled()
andTracer.nextSpan(Span)
, since the documents say the functions might return `null.Fixes #732
FinishedSpan.getKind()
is not annotated with@Nullable
, but its implementetion might returnnull
. I am no sure whether the implementation or the interface was wrong, so I didn't fix it.tracing/micrometer-tracing/src/main/java/io/micrometer/tracing/exporter/FinishedSpan.java
Lines 181 to 184 in 85a614a
tracing/micrometer-tracing-bridges/micrometer-tracing-bridge-otel/src/main/java/io/micrometer/tracing/otel/bridge/OtelFinishedSpan.java
Lines 259 to 261 in bc290c9
tracing/micrometer-tracing-bridges/micrometer-tracing-bridge-brave/src/main/java/io/micrometer/tracing/brave/bridge/BraveFinishedSpan.java
Lines 168 to 170 in d1383ae