Use TestObservationRegistry in context propagation tests #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatan-ivanov
force-pushed
the
enable-validation-for-scopes-tests
branch
2 times, most recently
from
65f5c87 to
4e8871f
Compare
jonatan-ivanov
approved these changes
Sep 5, 2024
Co-authored-by: Dariusz Jędrzejczyk <dariusz.jedrzejczyk@broadcom.com> Co-authored-by: Tommy Ludwig <8924140+shakuzen@users.noreply.github.com> Co-authored-by: Jonatan Ivanov <jonatan.ivanov@gmail.com>
jonatan-ivanov
force-pushed
the
enable-validation-for-scopes-tests
branch
from
4e8871f to
5f96098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to leverage
ObservationValidatorand can help improve theNullObservationimplementation. Currently the tests should fail so it's best to delay merging untilNullObservationinteroperability withObservationValidatoris improved.