Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docstrings in core.py and add compute_params and compute_metrics callbacks #63

Merged
merged 10 commits into from
Dec 5, 2023
Merged

Fix docstrings in core.py and add compute_params and compute_metrics callbacks #63

merged 10 commits into from
Dec 5, 2023

Conversation

fpaissan
Copy link
Collaborator

@fpaissan fpaissan commented Dec 2, 2023

Cosmetic updates to the core.py docstrings and torchinfo-based complexity estimation for MicroMind models.

@fpaissan fpaissan marked this pull request as draft December 2, 2023 19:16
@fpaissan fpaissan marked this pull request as ready for review December 4, 2023 09:48
matteobeltrami
matteobeltrami approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@matteobeltrami matteobeltrami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is ok. Ready to be merged!

@fpaissan fpaissan merged commit 5f002bb into micromind-toolkit:dev Dec 5, 2023
4 checks passed
This was referenced Dec 6, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteobeltrami matteobeltrami matteobeltrami approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fpaissan @matteobeltrami