Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't close application context between requests in MicronautRequestStreamHandler #1188

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Don't close application context between requests in MicronautRequestStreamHandler #1188

merged 2 commits into from
Oct 4, 2021

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Sep 28, 2021

Close #1187

@sdelamo sdelamo added the type: bug Something isn't working label Sep 28, 2021
@sdelamo
Copy link
Contributor Author

sdelamo commented Sep 28, 2021

@graemerocher I added a test which verifies the scenario described at #1187

I think that the fix is as easy as not closing the application context in MicronautRequestStreamHandler::close

Can you check it out?

@sdelamo sdelamo requested a review from ilopmar October 2, 2021 20:56
@sdelamo sdelamo merged commit 102ed56 into master Oct 4, 2021
@sdelamo sdelamo deleted the issue-1187 branch October 4, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilopmar ilopmar ilopmar approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MicronautStreamHandler closes MongoClient after processing request which is undesirable
3 participants
@sdelamo @graemerocher @ilopmar