Skip to content

Commit

Permalink
Fix "Duplicate entry for alias" error
Browse files Browse the repository at this point in the history
In case of nested BOM inlining, it was possible that we missed a case
where an alias was already included, which lead to the _Gradle_ (not ours)
warning "Duplicate entry for alias". However, we should avoid these,
because we already capture duplicate entries (which may be fine in case
we are actually overriding nested catalog versions).
  • Loading branch information
melix committed Oct 18, 2024
1 parent e7b0e10 commit f3d33f4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/groovy/io/micronaut/build/MicronautBomPlugin.java
Original file line number Diff line number Diff line change
Expand Up @@ -934,7 +934,7 @@ private void performNestedBomsInclusion(PrintWriter log,
var alias = convertToAlias(dep.getArtifactId());
var includeExcludeReason = shouldInclude(alias, includeAliases, includeAliasesPrefixes, excludeFromInlining, excludeFromInliningPrefixes);
if (includeExcludeReason.included()) {
if (knownAliasesSnakeCase.contains(alias)) {
if (knownAliasesSnakeCase.contains(alias) || knownAliases.containsKey(alias)) {
maybeWarn(knownAliases, alias, bomFileName);
} else {
if (knownVersionAliasesSnakeCase.contains(alias)) {
Expand Down

0 comments on commit f3d33f4

Please sign in to comment.