Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BOMs not being inlined #612

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix BOMs not being inlined #612

merged 1 commit into from
Sep 13, 2023

Commits on Sep 13, 2023

  1. Fix BOMs not being inlined

    This commit fixes a problem where some aliases were not inlined
    in the platform BOM. For example, the `junit` BOM dependency
    is missing from the platform, despite `micronaut-test` including
    it.
    
    The reason is that in `micronaut-test`, `junit` is a managed
    version, but for a BOM (alias `boms-...`). There were 2 ways
    to fix this problem:
    
    1. include all versions from the embedded catalog during
    inlining. This worked, but with a drawback: only the version
    would be included (e.g `junit`), but no library would be present.
    Which means that the user would still have to figure out the
    coordinates of, say, the junit BOM.
    2. the fix in this PR, which is to include `boms-` dependencies
    into the generated catalog. This works well and should be
    backwards compatible, since we're only adding new entries to
    the catalogs.
    
    It's worth noting that we _don't_ do this for `boms-micronaut-`
    entries, which, in this case, are available as independent
    version catalogs. Including them would lead to potentially
    many BOM inclusion conflicts, since many projects may include
    other Micronaut BOMs.
    
    Fixes #611
    melix committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    81b41f9 View commit details
    Browse the repository at this point in the history