Micronaut's UriMatchTemplate.match method doesn't work the same as how Spring's UriTemplate

[donbeave]

I'm migrating my application from Spring Boot to Micronaut and found out that UriMatchTemplate is not exactly the same. Probably it's a bug, I am not sure yet, to figure it out I created this issue.

The main difference is that match method will return empty Optional instead of the result, here is an example of my code.

I have this URL format:

private static final String URL_FORMAT = "https://www.mydomain.com/post/{postSlug}";

Spring Boot original code:

UriTemplate template = new UriTemplate(MOVIE_URL_FORMAT);

Map<String, String> match = template.match("https://www.mydomain.com/post/abc");

// will return `abc`
match.get("postSlug");

I have converted this code to Micronaut:

UriMatchTemplate template = UriMatchTemplate.of(URL_FORMAT);

// will return `Optional.empty`
Optional<UriMatchInfo> match = template.match("https://www.mydomain.com/post/abc")

I expect it will return UriMatchInfo object, where I can use getVariableValues method to retrieve the value for postSlug variable.

Example Application

Please clone this repo: https://github.com/donbeave/micronaut-uritemplate, here is two tests which compare Micronaut and Spring behavior:

1. https://github.com/donbeave/micronaut-uritemplate/blob/master/app/src/test/java/micronaut/uritemplate/SpringTest.java
2. https://github.com/donbeave/micronaut-uritemplate/blob/master/app/src/test/java/micronaut/uritemplate/MicronautTest.java

[graemerocher]

It is not a design goal for UriMatchTemplate to be the same as the Spring impl. I believe you can use:

private static final String URL_FORMAT = "https://www.mydomain.com/post/{postSlug+}";

To achieve the same behaviour in Micronaut

[donbeave]

I thought both of these classes implement the same specification: https://tools.ietf.org/html/rfc6570#page-21

I tried {postSlug+} and got the same result:

[graemerocher]

Apologies the + is actually before the path. See for examples

micronaut-core/http/src/test/groovy/io/micronaut/http/uri/UriMatchTemplateSpec.groovy

Line 72 in 74b67f0

void "Test URI template #template matches #uri"() {

If anything IMO Micronaut implements the spec more accurately. See “Reserved Expansion” section https://tools.ietf.org/html/rfc6570#section-3.2.3

[donbeave]

Hmm, for some reason it doesn't work too:

[graemerocher]

Seems the current implementation only supports relative paths such as /post/{+postSlug} for matching (expansion works fine)

Feel free to open a feature request for absolute URIs

[donbeave]

Ok, thank you! I will do.