-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deduceCloudEnvironment doesn't add "cloud" in AppEngine #10799
Comments
Confirmed not working in GAE:
|
Do you want to submit an PR? |
No, because there are no tests for this as far as I found, therefore it should be in scope to add regression tests, which is not as trivial as adding the line I highlighted. |
… for AppEngine" This reverts commit 6e39350.
Submitted a PR #11035 |
Relates to #10799 Cloud environment should be deduced for Google App Engine. Have added test cases for PCF_ENV, HEROKU_DYNO and K8S_ENV as well.
Expected Behavior
As documented:
Actual Behaviour
micronaut-core/inject/src/main/java/io/micronaut/context/env/DefaultEnvironment.java
Lines 742 to 747 in f3c28be
(compare to branches above, and notice that each add CLOUD explicitly.)
Steps To Reproduce
I haven't tried, I just stumbled upon the code.
Environment Information
https://cloud.google.com/appengine/docs/standard/java-gen2/runtime#environment_variables
Example Application
No response
Version
4.4.8
The text was updated successfully, but these errors were encountered: