Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graal annotation processor doesn't mark package-private injected fields for reflective access #10880

Closed
mikehearn opened this issue Jun 3, 2024 · 1 comment · Fixed by #10947
Closed

Graal annotation processor doesn't mark package-private injected fields for reflective access #10880

mikehearn opened this issue Jun 3, 2024 · 1 comment · Fixed by #10947
Assignees
@graemerocher
Labels
relates-to: graal type: bug Something isn't working

Comments

@mikehearn
Copy link
Contributor

Expected Behavior

Field injection in native images should work even for package-private fields in superclasses.

Actual Behaviour

Such fields are gone and the program throws an exception when it tries to reflect it for injection.

Steps To Reproduce

  1. Create a class hierarchy in which a controller inherits from an abstract superclass that contains an injected package-private field.
  2. Compile it with native image

Environment Information

No response

Example Application

No response

Version

4.4.0
@mikehearn
Copy link
Contributor Author

Graeme says that probably this logic is incorrect:

micronaut-core/graal/src/main/java/io/micronaut/graal/reflect/GraalTypeElementVisitor.java

Line 284 in 5372025

.getEnclosedElements(injectedMethodsThatNeedReflection

@graemerocher graemerocher added type: bug Something isn't working relates-to: graal labels Jun 3, 2024
@graemerocher graemerocher self-assigned this Jun 25, 2024
@graemerocher graemerocher mentioned this issue Jul 5, 2024
Merged
yawkat added a commit that referenced this issue Jul 17, 2024
@dstepanov @renovate
@lcavadas @andriy-dmytruk @micronaut-build @yawkat @alvarosanchez @graemerocher
Merge 4.5 into 4.6 (#10987)
e0bdce7 
* fix(deps): update netty monorepo to v4.1.111.final (#10905)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Ensuring the deserialization has access to the ServerRequestContext (#10904)

* Fixes #10665 Ensuring the deserialization has access to the ServerRequestContext

* Adding a test to ensure that large request payloads still have access to the ServerRequestContext on deserialization.

* Map of beans should always use bean definition to extract the name (#10908)

* Improve the ControllerConstraintHandlerTest to accept more HttpRequest body types (#10909)

* Add Kotlin+KSP+Jackson nullable tests (#10927)

The test is reproducing Jackson's default behaviour with primitives and a way to change it

micronaut-projects/micronaut-serialization#880

* Update common files (#10923)

* Revert "Improve the ControllerConstraintHandlerTest to accept more HttpReques…" (#10922)

This reverts commit 3744f17.

* chore(deps): update plugin io.micronaut.build.shared.settings to v6.7.1 (#10770)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency io.github.classgraph:classgraph to v4.8.174 (#8882)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update vertx to v4.5.8 (#10863)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update groovy monorepo to v4.0.22 (#10939)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency me.champeau.gradle:japicmp-gradle-plugin to v0.4.3 (#10885)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update junit5 monorepo (#10945)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update Micronaut Maven Plugin coordinates (#10946)

[skip ci]

* include all non-accessible methods in reflection data (#10947)

Fixes #10880

* Fix CompletableFuture responses without body (#10953)

Fixes #10917

* fix(deps): update dependency com.fasterxml.jackson.dataformat:jackson-dataformat-yaml to v2.17.2 (#10954)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Merge remote-tracking branch 'origin/4.5.x' into merge_4_5_6

# Conflicts:
#	http-server-netty/src/main/java/io/micronaut/http/server/netty/binders/NettyBodyAnnotationBinder.java
#	inject/src/main/java/io/micronaut/context/DefaultBeanContext.java

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Luís Serralheiro <encavadas@gmail.com>
Co-authored-by: Andriy Dmytruk <80816836+andriy-dmytruk@users.noreply.github.com>
Co-authored-by: micronaut-build <65172877+micronaut-build@users.noreply.github.com>
Co-authored-by: Jonas Konrad <jonas.konrad@oracle.com>
Co-authored-by: Álvaro Sánchez-Mariscal <alvaro.sanchez-mariscal@oracle.com>
Co-authored-by: Graeme Rocher <graeme.rocher@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@graemerocher graemerocher

Labels
relates-to: graal type: bug Something isn't working
Projects
4.5.1 Release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

include all non-accessible methods in reflection data micronaut-projects/micronaut-core
2 participants
@graemerocher @mikehearn