-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider including test dependency versions in Micronaut BOM #2298
Consider including test dependency versions in Micronaut BOM #2298
Comments
So I don't think we should be pinning the version of mockk or mockito because we don't have any code that relies any given version. You can use those mocking libraries or anything else. |
Although I don't mind specifying the versions myself it could benefit users to be honest. Just like I mean with both:
it's clearly I also will need the |
Yeah I specifically didn't mention the junit kotlintest runner and left this issue open because I'm not sure if that makes sense or not. To me the whole point of the BOM is to define dependency versions that are known to work together. If only specific versions of the junit runner work with specific versions of kotlintest then I think we should add it. |
@jameskleeh Our team moved away from that a long time ago, and as many previous issues I have submitted about maven enforcer issues, we make sure the transitive deps are pinned as well to MAKE sure our stuff works and lib versions are explicit NOT implicit. Micronaut use gradle and I am not sure if there is a similar plugin to https://maven.apache.org/enforcer/maven-enforcer-plugin/ for gradle. In our team BOMs we require and enforce transitive pinning. We have all our libs and the deps that conflict in versions included in the depMgmt sections. It would be the right answer to put anything with Our bom is also called micronaut-bom and has our internal group id and looks like this (just a snippet). I have included the fact that we have to add a bunch of pinned versions (like netty) due to micronaut bom using "lazy" (aka transitive) version resolution and many libraries across micronaut ask for different versions of netty libs which will fail compilation due to the enforcer plugin (which we want) so that we can make sure transitives are all using the same (and usually latest) versions of libs.
|
Currently adding kotlintest to a project looks like:
It would be nice if the
kotlintest-runner-junit5
andmockk``versions could be derived automatically from the Micronaut BOM like
junit-jupiter-api`.The same counts when using e.g. Spock or Mockito.
The text was updated successfully, but these errors were encountered: