Minor HTTP performance improvements #10441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yawkat
commented
Feb 1, 2024
yawkat
commented
- Use linux tcnative artifact for tests
- Negative compression threshold disables compression entirely
- Add an internal field to NettyHttpRequest for the NettyBodyAnnotationBinder convertible body cache, to avoid the attribute map
- Add a simple single-element cache to JacksonDatabindMapper for the reader/writer lookup
- Bypass ChannelPipeline.get if no logging handler is configured
- Use linux tcnative artifact for tests - Negative compression threshold disables compression entirely - Add an internal field to NettyHttpRequest for the NettyBodyAnnotationBinder convertible body cache, to avoid the attribute map - Add a simple single-element cache to JacksonDatabindMapper for the reader/writer lookup - Bypass ChannelPipeline.get if no logging handler is configured
dstepanov
reviewed
Feb 1, 2024
dstepanov
reviewed
Feb 1, 2024
| */ | ||
| @Internal | ||
| public ArgumentBinder.BindingResult<ConvertibleValues<?>> convertibleBody; | ||
|
|
There was a problem hiding this comment.
I was thinking we could have a custom object representing the body, which can accept some-kind of visitor, so we can avoid instanceof for cases when the body is known.
dstepanov
approved these changes
Feb 1, 2024
graemerocher
approved these changes
Feb 1, 2024
|
|
# Conflicts: # http-server-netty/build.gradle
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.