-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix process EachProperty configurations with abstract class for KSP #10523
Fix process EachProperty configurations with abstract class for KSP #10523
Conversation
@dstepanov Hi! Look to this, pls |
CI-CD is ok, just some problems with github action:
|
Does it fix something for Java as well? Maybe you can add a test for it too |
ae75367
to
c20bbb4
Compare
Hey, opener of #10505 here. How exactly does this fix the issue? I'm a little bewildered that all it is is changing how strings are concatenated (double quote vs single quote) and using empty strings from utils. My java skills are definitely not the strongest, but here I feel there is some hidden java knowledge I am just not aware of? 😅 |
@hrothwell It looks like the same issue that @altro3 is fixing |
Thanks @altro3! |
@dstepanov yes it is the issue @altro3 is fixing, I am wondering how this fixes it. I am unsure of how just updating some string concatenation is fixing the issue. I am asking more for my own knowledge and curiosity. Main confusion: what is the difference in the end result of |
Those are just code improvements, the main fix is |
see below |
Ah wait I missed a line, sorry about that. Thanks for pointing that out @dstepanov |
Fixed #10505