Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process EachProperty configurations with abstract class for KSP #10523

Merged

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Feb 21, 2024

Fixed #10505

@altro3
Copy link
Contributor Author

altro3 commented Feb 21, 2024

@dstepanov Hi! Look to this, pls

@altro3
Copy link
Contributor Author

altro3 commented Feb 21, 2024

CI-CD is ok, just some problems with github action:

2024-02-21T08:52:17.7500878Z в„№пёЏ - Java CI / Test Report (17) - 15379 tests run, 15279 passed, 100 skipped, 0 failed.
2024-02-21T08:52:17.7516214Z в„№пёЏ - Java CI / Test Report (17) - Creating check (Annotations: 0)
2024-02-21T08:52:18.0176377Z ##[error]вќЊ Failed to create checks using the provided token. (HttpError: Resource not accessible by integration)
2024-02-21T08:52:18.0180259Z ##[warning]вљ пёЏ This usually indicates insufficient permissions. More details: https://github.com/mikepenz/action-junit-report/issues/23

@dstepanov
Copy link
Contributor

Does it fix something for Java as well? Maybe you can add a test for it too

@hrothwell
Copy link
Contributor

Hey, opener of #10505 here. How exactly does this fix the issue? I'm a little bewildered that all it is is changing how strings are concatenated (double quote vs single quote) and using empty strings from utils. My java skills are definitely not the strongest, but here I feel there is some hidden java knowledge I am just not aware of? 😅

@dstepanov
Copy link
Contributor

@hrothwell It looks like the same issue that @altro3 is fixing

@dstepanov dstepanov added the type: bug Something isn't working label Feb 21, 2024
@dstepanov dstepanov merged commit e3f5fdb into micronaut-projects:4.3.x Feb 21, 2024
10 checks passed
@dstepanov
Copy link
Contributor

Thanks @altro3!

@hrothwell
Copy link
Contributor

hrothwell commented Feb 21, 2024

@dstepanov yes it is the issue @altro3 is fixing, I am wondering how this fixes it. I am unsure of how just updating some string concatenation is fixing the issue.

I am asking more for my own knowledge and curiosity.

Main confusion: what is the difference in the end result of string1 + "." + string2 and string1 + '.' + string2 in java? Are these not the same?

@dstepanov
Copy link
Contributor

Those are just code improvements, the main fix is return Optional.of(StringUtils.EMPTY_STRING);

@hrothwell
Copy link
Contributor

hrothwell commented Feb 21, 2024

So the main difference then just being a static empty string vs putting in a new "" empty string? Values are the same, so I guess the only other thing it could be is that static vs non-static?

see below

@hrothwell
Copy link
Contributor

Ah wait I missed a line, sorry about that. Thanks for pointing that out @dstepanov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

@EachProperty with abstract class override + KSP does not compile
3 participants