Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include serdeable metadata to internal JSON objects #10526

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Include serdeable metadata to internal JSON objects #10526

merged 2 commits into from
Feb 26, 2024

Conversation

dstepanov
Copy link
Contributor

This fixes one of the examples from micronaut-projects/micronaut-serialization#691
And eliminates the need for a custom deserializer for HealthStatus in Micronaut Serialization

Copy link

sonarcloud bot commented Feb 22, 2024

@dstepanov dstepanov merged commit 2a4e52f into 4.4.x Feb 26, 2024
15 checks passed
@dstepanov dstepanov deleted the herrs branch February 26, 2024 14:37
@sdelamo
Copy link
Contributor

sdelamo commented Feb 26, 2024

I think this PR creates a cycle between Serde and core and that it is a mistake.

sdelamo added a commit that referenced this pull request Mar 19, 2024
sdelamo added a commit that referenced this pull request Mar 19, 2024
This pull request adds the HealthResult serialization test introduced in #10526 as a TCK test.
sdelamo added a commit that referenced this pull request Mar 19, 2024
This pull request adds the JsonError test to verify JsonMapper can deserialize a JsonError as a GenericResource introduced in #10526 as a TCK test.
sdelamo added a commit that referenced this pull request Mar 20, 2024
This pull request adds the JsonError test to verify JsonMapper can deserialize a JsonError as a GenericResource introduced in #10526 as a TCK test.
sdelamo added a commit that referenced this pull request Mar 20, 2024
* tck: HealthResult serialization

This pull request adds the HealthResult serialization test introduced in #10526 as a TCK test.

* Unused imports and whitespace

* Try to fix the build... Switching base seems to have broken things

---------

Co-authored-by: Tim Yates <tim.yates@gmail.com>
sdelamo added a commit that referenced this pull request Mar 28, 2024
…#10623)

* Revert "Include serdeable metadata to internal JSON objects (#10526)"

This reverts commit 2a4e52f.

* add missing import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants