Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graal: reflect-config.json for hateoas classes #10547

Merged
merged 2 commits into from
Mar 12, 2024
Merged

graal: reflect-config.json for hateoas classes #10547

merged 2 commits into from
Mar 12, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Feb 26, 2024

No description provided.

@sdelamo
Copy link
Contributor Author

sdelamo commented Mar 7, 2024

@timyates can you investigate why this fails?

@timyates
Copy link
Contributor

timyates commented Mar 8, 2024

In both the regular and the native test, the recieved body json is

{"message":"Not Found","_links":{"self":{"href":"/jsonError","templated":false}},"_embedded":{"errors":[{"message":"Page Not Found"}]}}

We then call Optional<VndError> vndErrorOptional = ex.getResponse().getBody(VndError.class);

Optional<VndError> vndErrorOptional = ex.getResponse().getBody(VndError.class);

In the non-graal test, this passes, but in the native test we get back an Optional.empty()

Something must be up with deserialization and VndError... Any ideas @dstepanov ?

@sdelamo
Copy link
Contributor Author

sdelamo commented Mar 11, 2024

@timyates @dstepanov I added reflect-config configuration for the hateoas package classes.

@sdelamo sdelamo added type: bug Something isn't working relates-to: graal labels Mar 11, 2024
@sdelamo sdelamo changed the title tck: JsonError test graal: reflect-config.json for hateoas classes Mar 11, 2024
Copy link

sonarcloud bot commented Mar 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sdelamo sdelamo merged commit 985c271 into 4.3.x Mar 12, 2024
15 checks passed
@sdelamo sdelamo deleted the tck-json-error branch March 12, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relates-to: graal type: bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants