Handle parsing of form attributes with no value #10601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicronautHttpData.AttributeImpl is updated to provide an implementation of the setValue method. This implementation is needed in the corner cases where Netty's HttpPostStandardRequestDecoder successfully parses an attribute with no value such as in the body "a&b=2". Tests are added to more thoroughly test the various forms of x-www-form-urlencoded bodies as specified by https://url.spec.whatwg.org/#application/x-www-form-urlencoded. These tests include scenarios where we know and expect that HttpPostStandardRequestDecoder will currently fail to parse an attribute with a name but no value - namely when that attribute is the last one in a given POST body. If HttpPostStandardRequestDecoder is patched in the future, then these expected parsing failures can be moved into the success scenario instead. This partially resolves #10446.
yawkat
approved these changes
Mar 13, 2024
http-server-netty/src/main/java/io/micronaut/http/server/netty/MicronautHttpData.java
Outdated
Show resolved
Hide resolved
sdelamo
reviewed
Mar 13, 2024
graemerocher
approved these changes
Mar 13, 2024
|
Note that I have submitted a PR to Netty to fix the remaining cases that don't parse correctly: netty/netty#13904 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MicronautHttpData.AttributeImplis updated to provide an implementation of the setValue method. This implementation is needed in the corner cases where Netty'sHttpPostStandardRequestDecodersuccessfully parses an attribute with no value such as in the body "a&b=2".Tests are added to more thoroughly test the various forms of x-www-form-urlencoded bodies as specified by https://url.spec.whatwg.org/#application/x-www-form-urlencoded. These tests include scenarios where we know and expect that
HttpPostStandardRequestDecoderwill currently fail to parse an attribute with a name but no value - namely when that attribute is the last one in a given POST body. IfHttpPostStandardRequestDecoderis patched in the future, then these expected parsing failures can be moved into the success scenario instead.This partially resolves #10446.