Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency io.netty.incubator:netty-incubator-codec-http3 to v0.0.27.final #10603

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 13, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.netty.incubator:netty-incubator-codec-http3 (source) 0.0.25.Final -> 0.0.27.Final age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "after 10pm" in timezone Europe/Prague, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the type: dependency-upgrade Upgrade a dependency label Mar 13, 2024
@sdelamo
Copy link
Contributor

sdelamo commented Mar 13, 2024

@timyates can you investigate why the compilation failed on CI?

@timyates
Copy link
Contributor

In this code:

if (quic && ch instanceof QuicStreamChannel qsc) {
builder.forceTcpChannel((InetSocketAddress) qsc.parent().localAddress(), (InetSocketAddress) qsc.parent().remoteAddress(), true);
}

qsc.parent().localAddress() and qsc.parent().remoteAddress() used to return a java.net.SocketAddress

They now return a io.netty.incubator.codec.quic.QuicConnectionAddress which extends SocketAddress, and cannot be cast to a InetSocketAddress

@yawkat do you know what the fix is here?

@timyates
Copy link
Contributor

I guess for "incubator" modules, all semver bets are off?

@yawkat
Copy link
Member

yawkat commented Mar 13, 2024

fixed

@timyates
Copy link
Contributor

Copy link
Contributor Author

renovate bot commented Mar 13, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@yawkat
Copy link
Member

yawkat commented Mar 14, 2024

weird, QuicConnectionAddress is not referenced in the class file of HttpPipelineBuilder or NettyHttpServer$Listener

@timyates
Copy link
Contributor

@yawkat any ideas what we should do?

@yawkat
Copy link
Member

yawkat commented Mar 14, 2024

i think i found the culprit.

Copy link

sonarcloud bot commented Mar 14, 2024

@sdelamo
Copy link
Contributor

sdelamo commented Mar 14, 2024

thanks for the help @yawkat

@sdelamo sdelamo merged commit 7089853 into 4.3.x Mar 14, 2024
15 checks passed
@sdelamo sdelamo deleted the renovate/managed.netty.http3 branch March 14, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade Upgrade a dependency
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants