Remove build time initialisation of user metadata for GraalVM #10634
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems with strict image heap it is not safe to initialise anything that could represent user code. Previously we could get away with initialising our generated classes, but since this reference user classes the viral nature of build time init results in initialising user code.
This manifested in dev builds failing with an error on the
LogLevel
enum, I attempted to mark this is build time init but there are 2 problems with this:So unfortunately the only solution I see going forward is to completely remove the build time init or our generated metadata. This change does this and in local benchmarks does not seem to have a major impact on memory or startup, however does increase the image size by 2mb.
Fixes #10630