Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Use ApplicationContext.run(EmbeddedServer #10664

Merged
merged 1 commit into from
Mar 28, 2024
Merged

test: Use ApplicationContext.run(EmbeddedServer #10664

merged 1 commit into from
Mar 28, 2024

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Mar 28, 2024

This PR also adds some missing @requires spec.name to avoid test pollution.

@sdelamo
test: Use ApplicationContext.run(EmbeddedServer
0aaa18f 
This PR also adds some missing @requires spec.name to avoid test pollution.
@sdelamo sdelamo requested a review from yawkat March 28, 2024 14:09
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sdelamo sdelamo added the type: improvement A minor improvement to an existing feature label Mar 28, 2024
@yawkat yawkat merged commit b932cdf into 4.4.x Mar 28, 2024
17 checks passed
@yawkat yawkat deleted the run-embeddedserver branch March 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat Awaiting requested review from yawkat

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
4.4.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdelamo @yawkat