Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: expose context-propagation as api from http #10721

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Apr 16, 2024

I recently worked on a commercial support ticket where I need to add the context-propagation dependency.

micronaut-runtime exposes context-propagation as api.

However, the application was a groovy app. Thus, it was using micronaut-runtime-groovy. micronaut-runtime-groovy does not expose context-propagation.

I am not sure we should modify micronaut-runtime-groovy. Instead, this PR makes the http module expose context-propagation as api. http already exposes context as api.

I recently worked on a [commercial support ticket](https://micronaut.io/support/) where I need to [add the `context-propagation` dependency](sdelamo/mn-log-ip@42b559a). 

[`micronaut-runtime` exposes `context-propagation` as api](https://github.com/micronaut-projects/micronaut-core/blob/4.5.x/runtime/build.gradle#L11). 

However, the application was a groovy app. Thus, it was using `micronaut-runtime-groovy`. [`micronaut-runtime-groovy` does not expose `context-propagation`](https://github.com/micronaut-projects/micronaut-groovy/blob/4.4.x/runtime-groovy/build.gradle). 
This PR makes the `http` module expose `context-propagation` as `api`. [`http` already exposes `context` as api](https://github.com/micronaut-projects/micronaut-core/blob/4.5.x/http/build.gradle#L9).
@sdelamo sdelamo requested a review from dstepanov April 16, 2024 10:15
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sdelamo sdelamo merged commit 46b2dc8 into 4.5.x Apr 16, 2024
17 checks passed
@sdelamo sdelamo deleted the sdelamo-patch-8 branch April 16, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants