Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Http2ServerHandler by default #10732

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Enable Http2ServerHandler by default #10732

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0c554
Enable Http2ServerHandler by default
yawkat Apr 17, 2024
d634d31
move test to PendingFeatureIf
yawkat Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test-suite/src/test/groovy/io/micronaut/http/HttpAccessLogger.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import io.micronaut.test.extensions.spock.annotation.MicronautTest
import jakarta.inject.Inject
import org.slf4j.LoggerFactory
import reactor.core.publisher.Flux
import spock.lang.IgnoreIf
import spock.lang.PendingFeatureIf
import spock.lang.Specification

/**
Expand Down Expand Up @@ -108,8 +108,9 @@ class HttpAccessLoggerSpec extends Specification {

}

@IgnoreIf({ instance instanceof Http2AccessLoggerSpec }) // micronaut-session uses channel attributes to get the request, which is broken
void "test simple session - access logger"() {
@PendingFeatureIf({ instance instanceof Http2AccessLoggerSpec })
// micronaut-session uses channel attributes to get the request, which is broken
timyates marked this conversation as resolved.
Show resolved Hide resolved
void "test simple session - access logger"() {
when:
appender.events.clear()
Flux<HttpResponse<String>> flowable = Flux.from(client.exchange(
Expand Down
Loading