Support ExecuteOn annotation with ServerWebSocket #10772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NettyServerWebSocketHandler is updated to check for the ExecuteOn annotation when invoking any of the callback methods on a ServerWebSocket annotated class, and to use the specified ExecutorService when invoking the methods. A test is added to verify the enhanced behavior. This resolves #10758
yawkat
reviewed
Apr 29, 2024
...etty/src/main/java/io/micronaut/http/server/netty/websocket/NettyServerWebSocketHandler.java
Outdated
Show resolved
Hide resolved
jeremyg484
changed the title
yawkat
approved these changes
May 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NettyServerWebSocketHandler is updated to check for the ExecuteOn
annotation when invoking any of the callback methods on a
ServerWebSocket annotated class, and to use the specified
ExecutorService when invoking the methods.
A test is added to verify the enhanced behavior.
This resolves #10758